Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic arg mismatch errors being ignored with explicit late bound lifetimes #84410

Merged
merged 1 commit into from
May 1, 2021
Merged

Fix generic arg mismatch errors being ignored with explicit late bound lifetimes #84410

merged 1 commit into from
May 1, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 21, 2021

Fixes #83466

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2021
@varkor varkor added the F-const_generics `#![feature(const_generics)]` label Apr 21, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@varkor
Copy link
Member

varkor commented May 1, 2021

Thanks! Could you squash the commits? Then r=me.

@varkor
Copy link
Member

varkor commented May 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2021

📌 Commit 3905433 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 1, 2021
@Dylan-DPC
Rollup merge of rust-lang#84410 - BoxyUwU:blue, r=varkor
637b1e9 
Fix generic arg mismatch errors being ignored with explicit late bound lifetimes

Fixes rust-lang#83466

r? `@varkor`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 1, 2021
Closed
@bors
Copy link
Contributor

bors commented May 1, 2021

⌛ Testing commit 3905433 with merge 4de7572...

@bors
Copy link
Contributor

bors commented May 1, 2021

☀️ Test successful - checks-actions
Approved by: varkor
Pushing 4de7572 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2021
@bors bors merged commit 4de7572 into rust-lang:master May 1, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 1, 2021
@bors bors mentioned this pull request May 1, 2021
Merged
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Aug 26, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

ICE: wrong const argument causes a couple of ICE
7 participants
@BoxyUwU @rust-log-analyzer @varkor @bors @rust-highfive @lcnr @rustbot